From ce052fe7a457ddbd099c341c29fe5adb848f65f3 Mon Sep 17 00:00:00 2001
From: Benny Baumann <BenBE@geshi.org>
Date: Sun, 29 Sep 2019 02:11:42 +0200
Subject: [PATCH] fix: Crash when calling ui::display::sync
---
Makefile | 2 +-
src/ui/display.cpp | 2 ++
src/ui/display.hpp | 2 +-
3 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 41935d9..b187fe0 100644
--- a/Makefile
+++ b/Makefile
@@ -1,5 +1,5 @@
CFLAGS += -march=native -masm=intel -g -Og -fsanitize=address,signed-integer-overflow,undefined -pedantic -Wall -Wextra -Werror -Wduplicated-cond -Wduplicated-branches -Wlogical-op -Wrestrict -Wnull-dereference -Wdouble-promotion -Wshadow -Wformat=2 -Wfloat-equal -Wundef -Wpointer-arith -Wcast-align -Wstrict-overflow=5 -Wwrite-strings -Wswitch-default -Wswitch-enum -Wconversion -Wunreachable-code -Winit-self -fno-strict-aliasing -Wno-unknown-warning-option
-CXXFLAGS += ${CFLAGS} -std=c++11 -std=c++17 -Wuseless-cast -Weffc++ -I/usr/local/include
+CXXFLAGS += ${CFLAGS} -std=c++11 -std=c++17 -Wuseless-cast -Weffc++ -I/usr/local/include -Wno-non-virtual-dtor
DEPFLAGS = -MT $@ -MMD -MP -MF $(patsubst ${OBJDIR}/%.o,${DEPDIR}/%.d,$@)
PODOMAIN ?= rmrf
diff --git a/src/ui/display.cpp b/src/ui/display.cpp
index 9bef61b..41a3dfd 100644
--- a/src/ui/display.cpp
+++ b/src/ui/display.cpp
@@ -1,3 +1,5 @@
+#include "ui/display.hpp"
+
#include "lib/ncurses/ncurses.hpp"
#include "ui/view.hpp"
diff --git a/src/ui/display.hpp b/src/ui/display.hpp
index c47a80d..b18fd3a 100644
--- a/src/ui/display.hpp
+++ b/src/ui/display.hpp
@@ -15,7 +15,7 @@ namespace rmrf::ui {
* It implements some basic information handling and a registry for
* views.
*/
-class display : std::enable_shared_from_this<display> {
+class display : public std::enable_shared_from_this<display> {
public:
typedef display self_type;
typedef std::shared_ptr<self_type> ptr_type;
--
GitLab