fix some linting comlaints

.ansible-lint

+skip_list:
+  - 208
\ No newline at end of file

roles/base/tasks/gwvpn.yml

@@ -41,6 +41,7 @@
 # download public keys to your local machine
 - name: create public key files
   shell:
+    creates: /etc/fastd/ffhl_mesh_gwvpn/pubkey.key
     cmd: fastd --show-key -c /etc/fastd/ffhl_mesh_gwvpn/fastd.conf > /etc/fastd/ffhl_mesh_gwvpn/pubkey.key
 
 - name: fetch public keys

roles/base/tasks/main.yml

@@ -54,8 +54,10 @@
 - name: networkd templates
   tags: [systemd-networkd]
   block:
-    - template: src=network/10-ffhl.netdev.j2 dest=/etc/systemd/network/10-ffhl.netdev
-    - template: src=network/12-ffhl.network.j2 dest=/etc/systemd/network/12-ffhl.network
+    - name: apply network templates
+      template: src=network/10-ffhl.netdev.j2 dest=/etc/systemd/network/10-ffhl.netdev
+    - name: apply netowrk templates
+      template: src=network/12-ffhl.network.j2 dest=/etc/systemd/network/12-ffhl.network
     - name: copy network configs
       copy: src=systemd-networkd/ dest=/etc/systemd/network/
     - name: restart systemd-networkd
@@ -66,8 +68,10 @@
 - name: template iptables
   tags: [iptables, network]
   block:
-    - template: src=iptables/rules.v4 dest=/etc/iptables/rules.v4
-    - template: src=iptables/rules.v6 dest=/etc/iptables/rules.v6
+    - name: iptables4 template
+      template: src=iptables/rules.v4 dest=/etc/iptables/rules.v4
+    - name: iptables6 template
+      template: src=iptables/rules.v6 dest=/etc/iptables/rules.v6
     - name: reload iptables
       systemd:
         state: restarted

roles/base/tasks/mesh-vpn.yml

@@ -32,6 +32,7 @@
     repo: git@git.luebeck.freifunk.net:FreifunkLuebeck/fastd-keys.git
     dest: /var/local/ffhl-mesh-vpn-peers
     accept_hostkey: yes
+    version: HEAD
 
 - name: add post-merge hook
   template:

roles/base/tasks/powerdns.yml

@@ -26,6 +26,7 @@
     repo: "{{ dns_repo_url }}"
     dest: /var/local/ffhl-dns
     accept_hostkey: yes
+    version: HEAD
 
 - name: remove default bind-backend config
   file:

roles/base/tasks/units.yml

 ---
-- command: systemctl mask display-manager.service
 
-- command: systemctl daemon-reload
+- name: mask display-manager
+  systemd:
+    masked: yes
+    name: display-manager.service
+
+- name: reload systemd
+  systemd:
+    daemon_reload: yes
 
 # - name: stop bird
 #   systemd:

roles/base/tasks/update.yml

 ---
-- lineinfile:
+
+- name: check and add apt sources.list contents
+  lineinfile:
     path: /etc/apt/sources.list
     regexp: '^deb .* main'
-    line: deb http://deb.debian.org/debian stable main
+    line: deb http://deb.debian.org/debian bullseye main
+
 - name: update the system
   apt:
     update_cache: yes
+    upgrade: safe

roles/ffrhein-uplink/tasks/main.yml

 ---
-- lineinfile: state=present dest=/etc/iptables/iptables.rules line="-A POSTROUTING -o {{ snat_dev }} -j SNAT --to-source {{ snat_ip4 }}" insertafter="^\*nat$"
-- template: src=03-public-ip.network.j2 dest=/etc/systemd/network/03-public-ip.network
-- template: src=bird_ffrhein.conf.j2 dest=/etc/bird/bird_ffrhein.conf
+- name: add iptables rules
+  lineinfile: state=present dest=/etc/iptables/iptables.rules line="-A POSTROUTING -o {{ snat_dev }} -j SNAT --to-source {{ snat_ip4 }}" insertafter="^\*nat$"
+- name: add systemd-networkd .network configs
+  template: src=03-public-ip.network.j2 dest=/etc/systemd/network/03-public-ip.network
+- name: brid routing config
+  template: src=bird_ffrhein.conf.j2 dest=/etc/bird/bird_ffrhein.conf
   tags:
     - bird

roles/icvpn/tasks/main.yml

@@ -30,6 +30,7 @@
   git:
     repo: https://github.com/freifunk/icvpn.git
     dest: /etc/tinc/icvpn
+    version: HEAD
 
 - name: apply config template
   tags: [icvpn]

roles/icvpn/tasks/units.yml

 ---
-- systemd:
+- name: restart and enable units
+  systemd:
     enabled: yes
     state: restarted
     name: "{{ item }}"