Skip to content
Snippets Groups Projects
  • Adrian Schmutzler's avatar
    cfd1a405
    octeon: re-enable CONFIG_CAVIUM_CN63XXP1 and EdgeRouter image · cfd1a405
    Adrian Schmutzler authored
    
    The symbol CONFIG_CAVIUM_CN63XXP1 was disabled during the bump to
    4.19 (see Fixes:) with the following reason:
    
      No supported hardware uses CN63XXP1 and it causes "slight decrease
      in performance"
    
    However, it later turned out that the edgerouter image needed it,
    which led to having the device disabled in [1].
    Still, dropping support of a device seems a harsh action for just
    removing a "slight" decrease in performance from the other devices.
    
    Thus, this enables CONFIG_CAVIUM_CN63XXP1 again, and essentially
    restores the situation present until (including) kernel 4.14 on
    this target.
    
    For OpenWrt as a platform, it seems more desirable to support all
    devices (and have them tested regularly via the snapshots) in this
    case.
    Users interested in maximum performance might still just remove
    the symbol again in their local build.
    
    [1] 3824fa26 ("octeon: disable edgerouter image")
    
    Fixes: 6c225452 ("target/octeon: Add Linux 4.19 support")
    
    Signed-off-by: default avatarAdrian Schmutzler <freifunk@adrianschmutzler.de>
    cfd1a405
    History
    octeon: re-enable CONFIG_CAVIUM_CN63XXP1 and EdgeRouter image
    Adrian Schmutzler authored
    
    The symbol CONFIG_CAVIUM_CN63XXP1 was disabled during the bump to
    4.19 (see Fixes:) with the following reason:
    
      No supported hardware uses CN63XXP1 and it causes "slight decrease
      in performance"
    
    However, it later turned out that the edgerouter image needed it,
    which led to having the device disabled in [1].
    Still, dropping support of a device seems a harsh action for just
    removing a "slight" decrease in performance from the other devices.
    
    Thus, this enables CONFIG_CAVIUM_CN63XXP1 again, and essentially
    restores the situation present until (including) kernel 4.14 on
    this target.
    
    For OpenWrt as a platform, it seems more desirable to support all
    devices (and have them tested regularly via the snapshots) in this
    case.
    Users interested in maximum performance might still just remove
    the symbol again in their local build.
    
    [1] 3824fa26 ("octeon: disable edgerouter image")
    
    Fixes: 6c225452 ("target/octeon: Add Linux 4.19 support")
    
    Signed-off-by: default avatarAdrian Schmutzler <freifunk@adrianschmutzler.de>