-
- Downloads
ramips: remove bogus ralink,mtd-eeprom with offset 0x4
Several devices in mt76x8 subtarget use the following line to set up wmac in their DTS(I) files: ralink,mtd-eeprom = <&factory 0x4> This is strange for several reasons: - They should use mediatek,mtd-eeprom on this SOC - The caldata is supposed to start at 0x0 - The parent DTSI mt7628an.dtsi specifies mediatek,mtd-eeprom anyway, starting from 0x0 - The offset coincides with the default location of the MAC address in caldata Based on the comment in b28e94d4 ("ramips: MiWiFi Nano fixes"), it looks like the author for this device wanted to actually use mtd-mac-address instead of ralink,mtd-eeprom. A check on the same device revealed that actually the MAC address start at offset 4 there, so the correct caldata offset is 0x0. Based on these findings, and the fact that the expected location on this SOC is 0x0, we remove the "ralink,mtd-eeprom = <&factory 0x4>" statement from all devices in ramips (being only mt7628an anyway). Thanks to Sungbo Eo for finding and researching this. Reported-by:Sungbo Eo <mans0n@gorani.run> Fixes: b28e94d4 ("ramips: MiWiFi Nano fixes") Signed-off-by:
Adrian Schmutzler <freifunk@adrianschmutzler.de>
Showing
- target/linux/ramips/dts/mt7628an_cudy_wr1000.dts 0 additions, 1 deletiontarget/linux/ramips/dts/mt7628an_cudy_wr1000.dts
- target/linux/ramips/dts/mt7628an_rakwireless_rak633.dts 0 additions, 1 deletiontarget/linux/ramips/dts/mt7628an_rakwireless_rak633.dts
- target/linux/ramips/dts/mt7628an_totolink_lr1200.dts 0 additions, 1 deletiontarget/linux/ramips/dts/mt7628an_totolink_lr1200.dts
- target/linux/ramips/dts/mt7628an_vocore_vocore2.dtsi 0 additions, 1 deletiontarget/linux/ramips/dts/mt7628an_vocore_vocore2.dtsi
- target/linux/ramips/dts/mt7628an_xiaomi_miwifi-nano.dts 0 additions, 1 deletiontarget/linux/ramips/dts/mt7628an_xiaomi_miwifi-nano.dts
- target/linux/ramips/dts/mt7628an_zbtlink_zbt-we1226.dts 0 additions, 1 deletiontarget/linux/ramips/dts/mt7628an_zbtlink_zbt-we1226.dts
- target/linux/ramips/mt76x8/base-files/etc/board.d/02_network 2 additions, 2 deletionstarget/linux/ramips/mt76x8/base-files/etc/board.d/02_network
Please register or sign in to comment