Skip to content
Snippets Groups Projects
Commit a339e58d authored by Felix Fietkau's avatar Felix Fietkau
Browse files

ath9k: reduce the number of false positives triggered by the baseband hang...

ath9k: reduce the number of false positives triggered by the baseband hang check by only running it when beacon transmission is blocked

SVN-Revision: 24954
parent f38a320e
No related branches found
No related tags found
No related merge requests found
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -251,6 +251,9 @@ int ath_set_channel(struct ath_softc *sc
if (!ath_stoprecv(sc))
stopped = false;
+ if (!ath9k_hw_check_alive(ah))
+ stopped = false;
+
/* XXX: do not flush receive queue here. We don't want
* to flush data frames already in queue because of
* changing channel. */
@@ -602,7 +605,15 @@ void ath9k_tasklet(unsigned long data)
spin_lock(&sc->sc_pcu_lock);
- if (!ath9k_hw_check_alive(ah))
+ /*
+ * Only run the baseband hang check if beacons stop working in AP or
+ * IBSS mode, because it has a high false positive rate. For station
+ * mode it should not be necessary, since the upper layers will detect
+ * this through a beacon miss automatically and the following channel
+ * change will trigger a hardware reset anyway
+ */
+ if (ath9k_hw_numtxpending(ah, sc->beacon.beaconq) != 0 &&
+ !ath9k_hw_check_alive(ah))
ieee80211_queue_work(sc->hw, &sc->hw_check_work);
if (ah->caps.hw_caps & ATH9K_HW_CAP_EDMA)
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment