Skip to content
Snippets Groups Projects
  1. Sep 19, 2019
    • Álvaro Fernández Rojas's avatar
    • Álvaro Fernández Rojas's avatar
    • DENG Qingfang's avatar
      kernel: 4.19: fix crash when setting up spi-gpio · 1979af10
      DENG Qingfang authored
      If an spi-gpio was specified with num-chipselects = <0> in dts, kernel
      will crash:
      
       Unable to handle kernel paging request at virtual address 32697073
       pgd = (ptrval)
       [32697073] *pgd=00000000
       Internal error: Oops: 5 [# 1] SMP ARM
       Modules linked in:
       CPU: 2 PID: 1 Comm: swapper/0 Not tainted 4.19.72 #0
       Hardware name: Generic DT based system
       PC is at validate_desc+0x28/0x80
       LR is at gpiod_direction_output+0x14/0x128
       ...
       [<c0544db4>] (validate_desc) from [<c0545228>] (gpiod_direction_output+0x14/0x128)
       [<c0545228>] (gpiod_direction_output) from [<c05fa714>] (spi_gpio_setup+0x58/0x64)
       [<c05fa714>] (spi_gpio_setup) from [<c05f7258>] (spi_setup+0x12c/0x148)
       [<c05f7258>] (spi_setup) from [<c05f7330>] (spi_add_device+0xbc/0x12c)
       [<c05f7330>] (spi_add_device) from [<c05f7f74>] (spi_register_controller+0x838/0x924)
       [<c05f7f74>] (spi_register_controller) from [<c05fa494>] (spi_bitbang_start+0x108/0x120)
       [<c05fa494>] (spi_bitbang_start) from [<c05faa34>] (spi_gpio_probe+0x314/0x338)
       [<c05faa34>] (spi_gpio_probe) from [<c05a844c>] (platform_drv_probe+0x34/0x70)
      
      The cause is spi_gpio_setup() did not check if the spi-gpio has
      chipselect pins before setting their direction and results in derefing
      an invalid pointer.
      
      The bug is spotted in kernel 4.19.72 and does not occur in 4.14.
      
      There is a similar fix upstream in kernel 5.2 in commit 249e2632dcd0
      ("spi: gpio: Don't request CS GPIO in DT use-case").
      
      Ref: https://patchwork.kernel.org/patch/11150619/
      
      
      Signed-off-by: default avatarDENG Qingfang <dengqf6@mail2.sysu.edu.cn>
      [use upstream patch, moved from hack to pending dir, commit facelift]
      Signed-off-by: default avatarPetr Štetiar <ynezz@true.cz>
      1979af10
    • Jo-Philipp Wich's avatar
      procd: fix invalid JSON filter expression in procd_running() · c933b6d2
      Jo-Philipp Wich authored
      
      Since service and instance names may contain characters which are not allowed
      in JSON path labels, such as dashes or spaces, change the filter expression
      to array square bracket notation to properly match these cases as well.
      
      Fixes: 2c3dd707 ("procd: add procd_running() helper for checking running state")
      Signed-off-by: default avatarJo-Philipp Wich <jo@mein.io>
      c933b6d2
  2. Sep 18, 2019
  3. Sep 17, 2019
    • Hans Dedecker's avatar
      glibc: update to latest 2.27 commit (BZ#23637) · 2b342d01
      Hans Dedecker authored
      
      5b4f7382af Add undef to fix test failure.
      9456483fb2 Improve performance of memmem
      373f8b06a3 Improve performance of strstr
      4ec1b9e913 Fix strstr bug with huge needles (bug 23637)
      ecd6271ed8 Speedup first memmem match
      bba6b9288f Simplify and speedup strstr/strcasestr first match
      7a4da6ef7a Improve strstr performance
      
      Signed-off-by: default avatarHans Dedecker <dedeckeh@gmail.com>
      2b342d01
  4. Sep 16, 2019
  5. Sep 15, 2019
  6. Sep 14, 2019
    • Koen Vandeputte's avatar
      ar71xx: make IRQ fixes target specific · 1cf2495d
      Koen Vandeputte authored
      
      Move the IRQ fix from generic to ar71xx specific.
      Other targets like ath79 have specific pathes to delete this code.
      This resulted in a build failure on ath79
      
      While at it, wipe the 4.19 version, as ar71xx will never reach this.
      
      Fixes: 530f76708cef ("ar71xx: Fix potentially missed IRQ handling during
      dispatch")
      
      Signed-off-by: default avatarKoen Vandeputte <koen.vandeputte@ncentric.com>
      1cf2495d
    • Adrian Schmutzler's avatar
      brcm63xx: remove redundant variable definition in Makefile · 84c263eb
      Adrian Schmutzler authored
      
      For devices inheriting from bcm63xx_netgear, the IMAGES variable
      is overwritten with the same values as defined in the parent
      definition. So, remove the unnecessary overwrite.
      
      Signed-off-by: default avatarAdrian Schmutzler <freifunk@adrianschmutzler.de>
      84c263eb
    • Jonas Gorski's avatar
      images: fix boot failures on NAND with small sub pages · ee76bd11
      Jonas Gorski authored
      
      SquashFS has a minimum block size of at least 1k, so we need to make
      sure the last data block is also at least that big.
      
      This is not an issue on NOR or SD CARD devices, since their rootfs
      partitions go all the way to the end of the usable space.
      
      But on NAND with ubiblock, the rootfs partition will be the exact space,
      rounded up to LEB size. Unfortunately, some NAND chips with small sub
      pages have a LEB size of x.5 kiB. This can cause the the last data block
      to be less than 1k, which will cause the last block to be inaccessible,
      causing boot failures as seen on MR24:
      
      [    1.532960] block ubiblock0_3: created from ubi0:3(rootfs)
      [    1.538457] ubiblock: device ubiblock0_3 (rootfs) set to be root filesystem
      [    1.552847] SQUASHFS error: squashfs_read_data failed to read block 0x621472
      [    1.559896] squashfs: SQUASHFS error: unable to read id index table
      [    1.566474] VFS: Cannot open root device "(null)" or unknown-block(254,0): error -5
      
      Since on most NOR devices, the start of the squashfs partition is not
      aligned. Since the start of the rootfs_data partition there is dependend
      on the SquashFS size, we cannot just always pad it, as the padding could
      creep into the rootfs_data partition, breaking jffs2.
      
      So fix this by ensuring a squashfs rootfs is always a multiple of 1k
      only for UBI and NAND sysupgrade images.
      
      Fixes #2460 without affecting NOR devices.
      
      Tested-by: default avatarRussell Senior <russell@personaltelco.net>
      Signed-off-by: default avatarJonas Gorski <jonas.gorski@gmail.com>
      ee76bd11
  7. Sep 13, 2019
  8. Sep 12, 2019
    • Hans Dedecker's avatar
      odhcpd: fix update to git HEAD · ce6311d3
      Hans Dedecker authored
      
      Fixes commit 7ff5b12e
      
      e73bf11 config: ra_management compatibility support
      d818380 odhcpd: router: Fix out of scope memory access
      94a1c94 dhcpv6-ia: free assignment when validity timer expires
      752fc2c router: speed up initial router advertisements
      09aa022 router: close socket upon NETEV_IFINDEX_CHANGE fixed
      79eb160 router: fix previous commit
      6034b5c router: close socket upon NETEV_IFINDEX_CHANGE
      000182f router: fix lingering uloop socket descriptor
      f6c2242 router: support ra_lifetime being 0
      
      Signed-off-by: default avatarHans Dedecker <dedeckeh@gmail.com>
      ce6311d3
    • Ingo Feinerer's avatar
      umbim: update to latest git HEAD · ca0ad9e0
      Ingo Feinerer authored
      
      184b707 umbim: add home provider query support
      
      Signed-off-by: default avatarIngo Feinerer <feinerer@logic.at>
      ca0ad9e0
Loading